Return to site
Return to site

Bug Deep Dive #22

The protocol doesnt support weird tokens like Tether Gold (that return false on every operation)- $886

· Bug Deep Dive
Section image

The protocol uses the TransferHelper.safeTransferFrom(token, _currentTokenRequester, msg.sender, uint256(change)); for its token transfers. But this does not work if the token returns false for all the operations.

Tokens like Tether gold will cause the transfer to always revert. Thus such tokens are not supported by the protocol.

Section image

Alpha: in this case, the protocol intended to support weird behaviour on return values, but Tether gold is special because it returns false on success.

Conclusion

This finding would earn you $886, make sure to read the readme and the protocol messages to make sure you get all the in scope behaviours correctly! Also, keep track of weird tokens, listed here, for example.

Full Report
Codebase

Subscribe
Previous
Mentorship Series #17
Next
Bug Deep Dive #23
 Return to site
Cookie Use
We use cookies to improve browsing experience, security, and data collection. By accepting, you agree to the use of cookies for advertising and analytics. You can change your cookie settings at any time. Learn More
Accept all
Settings
Decline All
Cookie Settings
Necessary Cookies
These cookies enable core functionality such as security, network management, and accessibility. These cookies can’t be switched off.
Analytics Cookies
These cookies help us better understand how visitors interact with our website and help us discover errors.
Preferences Cookies
These cookies allow the website to remember choices you've made to provide enhanced functionality and personalization.
Save